Implement get_tipset_cid #568

fridrik01 · 2024-01-15T19:20:11Z

See #508

TODO:

Create a new "chain metadata" actor the state data model Akosh suggested in Implement FendermintExterns::get_tipset_cid #508 and using the the suggested interface in the task.
Bundle this actor in a separate bundle with its own manifest.
Load the new bundle at genesis.
Create new actor at genesis, constructing it with a len determined by a code constant.
Figure out how to obtain the blockhash at the right time within the ABCI pipeline so we can feed it in (take into account the case where the contract calls BLOCKHASH 0, i.e. the current block, this happens in immediate execution chains like CometBFT/Ignite, unlike Filecoin)
Figure out if we need to fork cron, or if we should have a dedicated cron, or if we should call push_blockcid individually.
Implement the get_tipset_cid syscall by calling ChainMetadata::blockcid()

Follow up tasks

fendermint/actors/chainmetadata/src/actor.rs

docs/fendermint/running.md

fendermint/actors/build.rs

fendermint/actors/chainmetadata/src/shared.rs

fendermint/actors/src/manifest.rs

fendermint/app/config/default.toml

fendermint/vm/interpreter/src/fvm/exec.rs

fendermint/vm/interpreter/src/fvm/genesis.rs

fendermint/actors/chainmetadata/src/lib.rs

fendermint/actors/chainmetadata/Cargo.toml

fendermint/actors/chainmetadata/src/actor.rs

Also move the fil_actors_runtime as an optional dependency that is only required when fil-actor feature is set

- create chainmetadata module actor_interface - identify custom actors by name and skip code id

Instead we return the same blockhash as was added, and then we let the caller deal with converting to cid.

aakoshh · 2024-01-25T16:35:10Z

fendermint/testing/contracts/Greeter.sol

+        //uint256 number = uint256(blockhash(block.number - 1));
+        bytes32 myHash = blockhash(block.number - 1);
+
+        return string(abi.encodePacked(myHash));


This will fail another integration test, namely this one called from here.

I can imagine it has been committed by mistake, but just to clarify, what I thought would be a nice integration test for this is to add a contract very similar to Greeter.sol to testing/contracts that has a function to return the e.g. BLOCKHASH(1), then add an example right next to greeter.rs which is again very similar in that it deploys this contract, then calls it similar to how that one calls greet(), and finally retrieves the block by height to compare the hash against what the contract returned.

The Greeter contract should be left alone to avoid any confusion as it was taken verbatim from another repo where it served the same purpose of testing The Graph.

sorry, this was accidentally committed, it was just what I used for testing

fendermint/vm/interpreter/src/fvm/externs.rs

fridrik01 · 2024-01-25T16:39:19Z

Working on fixing CI, there was some issue when rebasing, and now getting cargo errors failing to select a version for a package

The fix was to removing "crypto" feature from fvm_shared dependency in contracts/binding/Cargo.toml, recompile, and then add it back.

fridrik01 · 2024-01-26T14:26:12Z

Cargo.toml

-# We can work around it by hardcoding the method hashes; currently there is only one.
-# frc42_dispatch = "3.2"
+# We need a version of frc42_dispatch that has been updated to use FVM 4.1
+frc42_dispatch = { git = "https://github.com/fridrik01/filecoin.git", branch = "update-fvm-4.1" }


Note, that I needed to fork this repo to update it to FVM 4.1. I have a PR for merging this into the official repo (filecoin-project/actors-utils#231)

fendermint/testing/contracts/Greeter.bin

aakoshh

Great! I'm not sure why Greeter.bin changes, but as long as CI passes, let's go!

fridrik01 force-pushed the chain-metadata-actor branch 2 times, most recently from ebfd26b to 72b8033 Compare January 15, 2024 19:24

fridrik01 changed the title ~~[WIP] Add chain metadata actor~~ [WIP] Implement get_tipset_cid Jan 16, 2024

fridrik01 force-pushed the chain-metadata-actor branch 2 times, most recently from 340b854 to 70c8d99 Compare January 16, 2024 17:10

fridrik01 marked this pull request as ready for review January 18, 2024 19:23

aakoshh reviewed Jan 19, 2024

View reviewed changes

fendermint/actors/chainmetadata/src/actor.rs Outdated Show resolved Hide resolved

fridrik01 force-pushed the chain-metadata-actor branch 2 times, most recently from bceae76 to e72eb8c Compare January 22, 2024 10:23